fix(astro): set the image endpoint entrypoint so /_image works - #679
Merged
Conversation
`image.endpoint` is an object (`{ route, entrypoint }`), not a string, so
`config.image.endpoint ?? "astro/assets/endpoint/node"` never fired — the object
is always truthy. The entrypoint was therefore never set, no /_image route was
built, and every optimized image 404'd at runtime while the adapter advertised
`sharpImageService: "stable"`.
Sets `entrypoint` inside the object, keeping Astro's dev endpoint for `astro dev`
and using the Node one for builds, and passes `route` through so a custom route
still works. Mirrors @astrojs/node's own handling.
Verified on App Hosting deployments of Astro 5, 6 and 7, checking the served
image's dimensions, file type and quality.
leoortizz
requested review from
Yuangwang,
abhis3,
annajowang and
falahat
as code owners
August 12, 2026 16:09
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces dynamic resolution of the Astro image endpoint entrypoint based on the execution command (e.g., using the dev endpoint for astro dev and the Node endpoint for builds), along with corresponding unit tests. The reviewer identified a potential crash if config.image.endpoint is undefined, and suggested using optional chaining to safely access its properties.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Yuangwang
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
image.endpointis an object ({ route, entrypoint }), not a string, soconfig.image.endpoint ?? "astro/assets/endpoint/node"never fired — the objectis always truthy. The entrypoint was therefore never set, no /_image route was
built, and every optimized image 404'd at runtime while the adapter advertised
sharpImageService: "stable".Sets
entrypointinside the object, keeping Astro's dev endpoint forastro devand using the Node one for builds, and passes
routethrough so a custom routestill works. Mirrors @astrojs/node's own handling.
Verified on App Hosting deployments of Astro 5, 6 and 7, checking the served
image's dimensions, file type and quality.