fix: true median for peak consensus boundaries - #135
Merged
Conversation
mrvollger
force-pushed
the
fix/median-changelog-line
branch
from
August 22, 2026 03:31
9e25430 to
dad4a6f
Compare
mrvollger
force-pushed
the
fix/median-changelog-line
branch
from
August 22, 2026 03:31
dad4a6f to
565f128
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog restoration: the actual fix shipped inside the #129 squash (consensus start/end were the upper median of pooled FIRE element edges, landing on one element's bounds whenever contributors tied; even counts now take the midpoint of the two middle values — 10 of 31 ctcf call-peaks boundaries shifted by 1–33 bp, summits and statistics unchanged). Squashing folded it into the union-peaks feat entry, so v0.14.0's changelog had no Fixed line for it. This PR carries the doc comment for the median function and, through its squash title, restores the changelog entry.