feat: default min_frac_accessible to 0.10 - #66
Merged
Conversation
FIRE peaks now require >=10% of reads accessible on top of FDR peak calling by default; set min_frac_accessible: 0.0 for the old behavior. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #62. FIRE peaks must now have at least 10% of reads accessible (
fire_coverage/coverage >= 0.10, applied inmerge_fire_peaks.py) in addition to passing FDR peak calling. Setmin_frac_accessible: 0.0to restore the old behavior.On the test dataset this removes no peaks (all peaks there exceed 19% accessibility), so test outputs are unchanged; on real WGS data marginal peaks will be filtered.