chore(deps): pin prettier to an exact version - #26
Merged
Conversation
prettier was ranged ^3.8.1. That range is what let the format check start failing on .github/ISSUE_TEMPLATE without anything in the repository changing: 3.9.6 treats code fences inside markdown differently, and the formatting rules moved under the repo when the lockfile did. CI runs npm ci, so it was never nondeterministic. The hazard is that a local npm install or a dependency bump moves the lockfile, and a formatting rule change arrives as a CI failure on the next unrelated pull request rather than as a diff anyone reviewed. Pinned at 3.9.6, which is what the lockfile already resolved to, so nothing reformats here. An upgrade now shows up as a deliberate one-line change with whatever reformatting it causes in the same diff. No changeset: this is tooling only and does not touch the published package. Verified with npm run format:check, npm run lint, npm run typecheck, npm test (159 passing), and npm run build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #24, which fixed the symptom. This removes the cause.
What actually went wrong
prettierwas ranged^3.8.1. 3.9.6 treats code fences inside markdown differently, so when the lockfile moved to it,.github/ISSUE_TEMPLATE/started failingformat:checkwith nothing in the repository having changed. It surfaced as a CI failure on #23, a PR that touched onlysrc/schemas/.Worth being precise about the failure mode: CI was never nondeterministic. It runs
npm ciagainst a committed lockfile. The hazard is that a localnpm installor a dependency bump moves the lockfile, and a formatting-rule change then arrives as a CI failure on the next unrelated PR rather than as a diff someone reviewed.The change
Pinned at
3.9.6, which is what the lockfile already resolved to. Nothing reformats. The only diff is the declared range and the matching lockfile entry.An upgrade from here is a deliberate one-line change, and whatever reformatting it causes lands in the same diff as the version bump, where it can be reviewed on purpose.
No changeset: tooling only, and it does not touch the published package. Same call as #24.
Verification
npm run format:check,npm run lint,npm run typecheck,npm test(159 passing),npm run buildall clean.Not done here
Two sibling repos carry the same floating range and the same latent hazard:
seamless-auth-api^3.8.1seamless-auth-react^3.6.2Both pass
format:checktoday, so neither is broken, but both can go the way this one did. Left out of this PR because they are separate repositories rather than because they are fine. Happy to open the same change in each.