Skip to content

Improve committee page load - #7207

Open
patphongs wants to merge 3 commits into
developfrom
feature/7107-improve-committee-page-load
Open

Improve committee page load#7207
patphongs wants to merge 3 commits into
developfrom
feature/7107-improve-committee-page-load

Conversation

@patphongs

@patphongs patphongs commented Aug 6, 2026

Copy link
Copy Markdown
Member

Summary (required)

Defers committee About and Filings API calls until those tabs are requested. Adds server rendered tab partials while keeping direct ?tab= URLs working.

Note: views.py changes looks larger than it is because much of the diff moves existing committee context building code into shared helpers. That lets the full committee page and the deferred tab partials reuse the same context while keeping reports/totals and tab specific API calls out of partial renders.

Required reviewers

1 frontend engineer

Impacted areas of the application

General components of the application that this PR will affect:

  • Committee profile pages
  • About and Filings tab loading
  • Committee page tab navigation

How to test

  • Run npm run build-js.
  • Load any committee page such as /data/committee/C00003418/?cycle=2026.
  • Confirm initial load skips About F1/sponsor calls and raw efiling server data calls.
  • Click About tab and confirm /data/committee/C00003418/tab/about-committee/?cycle=2026 loads the tab content.
  • Click Filings tab and confirm /data/committee/C00003418/tab/filings/?cycle=2026 loads the tab content.
  • Confirm direct URLs still work:
    • /data/committee/C00003418/?cycle=2026&tab=about-committee
    • /data/committee/C00003418/?cycle=2026&tab=filings
  • Test the cycle dropdowns to make sure you can switch cycles on the about-committee and filings tabs
  • Run pytest.

@patphongs patphongs changed the title Feature/7107 improve committee page load Improve committee page load Aug 6, 2026

@johnnyporkchops johnnyporkchops left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearing review comment because it was in-deletable. Reviewing PR now

@johnnyporkchops
johnnyporkchops self-requested a review August 6, 2026 21:35

@johnnyporkchops johnnyporkchops left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patphongs I noticed that the cycle selects do not fire on-change on About or Filings tabs.
Also when going from About to Filings tab, the currently selected cycle is not preserved which we could arguably sacrifice for the performance improvement if the cycle selects worked once the tab loaded.

@JonellaCulmer JonellaCulmer added this to the 32.6 milestone Aug 12, 2026
@patphongs patphongs moved this to 👀 Ready in Website project Aug 20, 2026
@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.02439% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.85%. Comparing base (efe5dc3) to head (d09a1b2).
⚠️ Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
fec/data/views.py 75.67% 18 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7207      +/-   ##
===========================================
+ Coverage    79.45%   79.85%   +0.39%     
===========================================
  Files          256      256              
  Lines         6738     6865     +127     
===========================================
+ Hits          5354     5482     +128     
+ Misses        1384     1383       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@johnnyporkchops johnnyporkchops left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patphongs The cycle selects seems to work now and persist when navigating tabs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 👀 Ready

Development

Successfully merging this pull request may close these issues.

Improve committee page load

3 participants