Improve committee page load - #7207
Conversation
johnnyporkchops
left a comment
There was a problem hiding this comment.
@patphongs I noticed that the cycle selects do not fire on-change on About or Filings tabs.
Also when going from About to Filings tab, the currently selected cycle is not preserved which we could arguably sacrifice for the performance improvement if the cycle selects worked once the tab loaded.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7207 +/- ##
===========================================
+ Coverage 79.45% 79.85% +0.39%
===========================================
Files 256 256
Lines 6738 6865 +127
===========================================
+ Hits 5354 5482 +128
+ Misses 1384 1383 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
johnnyporkchops
left a comment
There was a problem hiding this comment.
@patphongs The cycle selects seems to work now and persist when navigating tabs
Summary (required)
Defers committee
AboutandFilingsAPI calls until those tabs are requested. Adds server rendered tab partials while keeping direct?tab=URLs working.Note:
views.pychanges looks larger than it is because much of the diff moves existing committee context building code into shared helpers. That lets the full committee page and the deferred tab partials reuse the same context while keeping reports/totals and tab specific API calls out of partial renders.Required reviewers
1 frontend engineer
Impacted areas of the application
General components of the application that this PR will affect:
How to test
npm run build-js./data/committee/C00003418/?cycle=2026.AboutF1/sponsor calls and raw efiling server data calls.Abouttab and confirm/data/committee/C00003418/tab/about-committee/?cycle=2026loads the tab content.Filingstab and confirm/data/committee/C00003418/tab/filings/?cycle=2026loads the tab content./data/committee/C00003418/?cycle=2026&tab=about-committee/data/committee/C00003418/?cycle=2026&tab=filingsabout-committeeandfilingstabspytest.