add queries for generalized horizons which support yearly, monthly and daily auctions properly - #8
Conversation
| # pretify the results since we know it is for monthly auction | ||
| # prettify the results to only show the first products and results | ||
| data = data[0] | ||
| data = {**data, **data['results'][0], **data['products'][0]} |
There was a problem hiding this comment.
This returns only the results from the first auction with this ID.
When having daily products, 24 biddings exist with the same ID, which have a different date (one for each hour).
This is currently not reflected in the auctions code.
A split to multiple datasets:
- auctions
- results
- products
would help here, though this is much more work.
I don't know what you think @fboerman - maybe it surely is worth it to provide the option to consistently download data for the different horizons as well here..?
There was a problem hiding this comment.
hmm that is an interesting one, I dont really have the time to go through this given that I dont use it myself. If you want to take a crack at this feel free!
|
hi! thanks for the work! do you have a quick snippit to test some things? then after that I will merge it! |
2 participants
This project did not correctly handle queries to daily horizon, as the day was always set to 1 (as needed for the month queries).
By introducing two new functions:
query_auction_detailsandquery_auction_statsthis is now properly handled and can be extended (I did not find corridors which have other horizons than the named available).The previous monthly queries are mapped to call the generalized functions, to not break existing code.