fix: negotiate encoding before compression checks - #425
Open
pratik-desgn wants to merge 1 commit into
Open
Conversation
Signed-off-by: Pratik Dulal <pratikdulal0@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #305.
The compression paths currently negotiate
Accept-Encodinginside the last operand of a short-circuitingnoCompressexpression. Whenx-no-compressionor a non-compressible content type matches first,encodingremains undefined and a configuredonUnsupportedEncodinghandler is called even for a supported encoding.This change negotiates the encoding before evaluating the skip conditions in both the global
onSendhook andreply.compress()paths. It adds regression coverage for each path and verifies that the response is passed through without invoking the unsupported-encoding handler.This supersedes the voluntarily closed draft #404 and is rebased on current
main.Validation:
npm run lintnpm test— 236 unit tests and 10 type assertions passedgit diff --checknpm run benchmark --if-presentcompleted all measurements, but its unchanged 8 KiB streaming control varied by 25% and exceeded the 10% noise tolerance; the benchmark reports this as machine noise and recommends rerunning on an idle machine before drawing conclusionsChecklist
npm run test && npm run benchmark --if-present