Skip to content

Apply model and optimizer state after checkpoint load - #103

Open
WangXukang-cypher wants to merge 2 commits into
facebookresearch:mainfrom
WangXukang-cypher:fix-checkpoint-state-restore
Open

Apply model and optimizer state after checkpoint load#103
WangXukang-cypher wants to merge 2 commits into
facebookresearch:mainfrom
WangXukang-cypher:fix-checkpoint-state-restore

Conversation

@WangXukang-cypher

Copy link
Copy Markdown

Summary

Distributed checkpoint loading currently populates the state-dict containers with torch.distributed.checkpoint.load, but does not explicitly apply the loaded state to the model and optimizer.

This change completes the checkpoint loading flow by:

  • Applying model-only checkpoints with set_model_state_dict.
  • Applying combined model and optimizer checkpoints with set_state_dict.
  • Updating both the initial checkpoint loading path and the training resume path.
  • Adding CPU regression tests for model and optimizer state restoration.

The optimizer regression test verifies that AdamW per-parameter state is installed on the resumed optimizer rather than only remaining in the temporary state-dict container.

Test plan

  • Run the model-only checkpoint restoration test.
  • Run the model and optimizer restoration test.
  • Run Ruff static checks on the new tests.
  • Run Ruff formatting checks on the new tests.
  • Compile the modified Python files.
  • Run git diff --check.
  • Run IDE lint checks.

Results

2 passed in 0.85s

Signed-off-by: Sh0rck_Wang <wangxukang010406@outlook.com>
@meta-cla

meta-cla Bot commented Sep 4, 2026

Copy link
Copy Markdown

Hi @WangXukang-cypher!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Signed-off-by: Sh0rck_Wang <wangxukang010406@outlook.com>
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant