[Nexthop] Fix AgentQueuePerHost tests for G202X - #1448
Open
vvasavada-nexthop wants to merge 2 commits into
Open
Conversation
Signed-off-by: Vishrant Vasavada <vvasavada@nexthop.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
On some platforms, split horizon check is after ACL matching. Thus, the counter increment can happen one additional time for the looped back packet in queue per host tests. For G202X, we need to do a fix similar to https://github.com/facebook/fboss/blob/main/fboss/agent/test/agent_hw_tests/AgentQueuePerHostL2Tests.cpp#L114-L136 in other queue per host tests.
Since the pattern would be repeated in many queue per host tests, we just implement a helper
getQueuePerHostExpectedLoopbackPktCountand let all the tests use that helper to verify pkt count.getQueuePerHostExpectedLoopbackPktCountreturn double the expected pkt count passed for EBRO, P200, YUBA and G202X ASICs while returns it as is for other ASICs.Test Plan
The tests pass after the fix.
Also verified that there's no regression in queue per host L2 tests that were changed to use new helper.