gc2: es: Add retry for unexpected VR IC_DEVICE_ID reads - #2759
Open
Joseph-Shih-ww wants to merge 1 commit into
Open
gc2: es: Add retry for unexpected VR IC_DEVICE_ID reads#2759Joseph-Shih-ww wants to merge 1 commit into
Joseph-Shih-ww wants to merge 1 commit into
Conversation
[Task Description] - Related to GC20T5T7-284. - BIC VR module detection may misidentify the populated VR IC when the PMBus IC_DEVICE_ID read returns an unexpected or unrecognized value. - Vendor analysis indicated that this may occur when a BIC reset interrupts an in-flight I2C transaction and the previous transaction does not complete with a STOP condition before IC_DEVICE_ID is read. - Add retry handling so BIC re-reads and re-matches IC_DEVICE_ID against known VR signatures before falling back to the default VR module type, reducing false detection caused by transient I2C read failures. [Motivation] - detect_vr_module_via_pmbus() previously performed only one PMBus read of IC_DEVICE_ID. - If the read failed or the returned value did not match any known VR signature (TPS53689 / XDPE15284D / ISL69259), the function immediately fell back to VR_MODULE_ISL69259. - Because an I2C transaction can be interrupted by a BIC reset, a single failed or unexpected IC_DEVICE_ID read may be transient and should not be treated as conclusive. [Design] - Wrap the IC_DEVICE_ID read-and-match flow in a retry loop with a maximum of 5 attempts. - Retry after a 50 ms delay when the PMBus read fails or the returned IC_DEVICE_ID does not match any known VR signature. - Add LOG_INF/LOG_ERR messages for successful detection, per-attempt read failures, and unrecognized IC_DEVICE_ID values for debugging. - Fall back to the existing default, VR_MODULE_ISL69259, only after all retry attempts are exhausted.
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D115870568. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Task Description]
[Motivation]
[Design]