Skip to content

sb: el: sync 2026.29.01 release update - #2758

Open
S-J-Tang wants to merge 10 commits into
facebook:mainfrom
S-J-Tang:sb-el-20262901-release
Open

sb: el: sync 2026.29.01 release update#2758
S-J-Tang wants to merge 10 commits into
facebook:mainfrom
S-J-Tang:sb-el-20262901-release

Conversation

@S-J-Tang

Copy link
Copy Markdown
Contributor

Summary

Sync the SB-EL 2026.29.01 release changes onto the latest upstream main branch.

Features

  • Refactor VR over-temperature checking.
  • Update VR firmware version output and skip unsupported 3V3 queries.
  • Fix the blackbox index issue.
  • Adapt to the CPLD V7 register table.
  • Refactor quick sensor polling and consolidate DC-on delay handling.
  • Obtain the VOUT range from sensor thresholds.
  • Update sensor data formats to support signed 32-bit values.

Included releases

  • 2026.29.01

Test Plan

  • Build SB-EL : Pass

adamHSU and others added 9 commits August 13, 2026 20:18
…tion

Summary:
- Move VR over-temperature check from CPLD polling function into get_error_data function
- Consolidate VR hot flag assertion logic to improve code readability
Test Plan:
- Build code: Pass
- Function test: Pass
Summary:
- Skip `COMPNT_VR_3V3` FW version query on non-EVB boards
- Change remain string from `", Remaining Write: "` to `", Remain: "`
- Append VR rail name to the FW version output
- Change VR FW pre/post hook failure log from `LOG_DBG` to `LOG_ERR`

Test Plan:
- Build code: Pass
Summary:
- Fix index bug for blackbox.
Test Plan:
- Build code: Pass
Summary:
- Updated code to match CPLD V7 register table revision
- Merged register 0xC4 into register 0x26
Test Plan:
- Build code: Pass
…y timing

Summary:
- Restructured quick_sensor_poll_handler for easier future extension
- Added DC_ON_DELAY_TIMING define to replace scattered hardcoded dc on delay values (e.g. magic number 1500)
Test Plan:
- Build code: Pass
Summary:
- Use sensor critical high and low thresholds to get VR vout range
- Return vout max/min in millivolt based on PDR threshold values

Test Plan:
- Build code: Pass
Summary:
- Skip `COMPNT_VR_3V3` FW version query on Electra platform
- Add log message when 3V3 VR FW version query is not supported

Test Plan:
- Build code: Pass
Summary:
- Change `sensor_data_size` from `0x04` to `0x05`
- Change `range_field_format` from `0x04` to `0x05`
- Add `sint32` support for sensor readings and threshold range fields

Test Plan:
- Build code: Pass
Summary:
- Version commit for 2026.29.01.

Test Plan:
- Build code: Pass
- Function check: Pass
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 13, 2026
@meta-codesync

meta-codesync Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

This pull request has been imported. If you are a Meta employee, you can view this in D115867685. (Because this pull request was imported automatically, there will not be any future comments.)

@facebook-github-tools

Copy link
Copy Markdown

@S-J-Tang has updated the pull request. You must reimport the pull request before landing.

Summary:
- Fix code formatting issues with clang-format
- Rename the local I2C device variable to avoid variable shadowing
- Align source formatting with project style

Test Plan:
- Build code: Pass
- Cppcheck: Pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant