Size header logos by height instead of width - #259
Open
amjadr360 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: https://github.com/extendify/company-product/issues/2393
The site-logo block's
widthattribute makes WP core recompute theimage's intrinsic size from that width (site-logo.php:18-24), so a
landscape logo at width:40 renders 40px wide and ~10px tall. Setting
widthalso drops theis-default-sizeclass, which is the onlyselector the theme's existing logo clamp targets — the
max-height: 42px; width: autorule in style.css:403. These threeheaders were opting themselves out of the one rule that already
handles both square and landscape logos.
Removing the attribute puts them back on that clamp. It also makes
them agree with the Extendify API redesign preview, which renders the
logo under the same 42px max-height — the mismatch reported in
company-product#2393, where the preview showed a legible wordmark and
the built site showed a sliver.
Catalina Skyline goes from 48px to the shared 42px; Atlas Beacon and
Ceadar Peak from 40px.