ci: trigger npm publish on release published and set dist-tag - #768
Conversation
106460b to
e7e0c6b
Compare
|
I will merge it and re-create the 1.20.7 release to test it out |
|
I would prefer using tags as @blakeembrey does: https://github.com/jshttp/content-disposition/blob/master/.github/workflows/release.yml |
|
It worked as expected: https://github.com/expressjs/body-parser/actions/runs/34215333441/job/102025635884
I always produce releases as I like to include the auto-generated notes (to notify the people around shipped changes). If we trigger npm publications on tags we might forget to do releases as is a manual step but I am open to change it if we believe is better. Also not all the packages use |
I believe you could create a draft release as the final step, that would be really neat to have.
I went with tags to avoid the indeterminate timeline between the tag and actual release. Especially since we wanted to use environments in GitHub to authorize the release first, and another step in NPM with staging, it could mean a while between starting the releasing and having it be available.
It's what |

Main Changes