chore(ci): npm-publish via reusable workflows - #766
Conversation
krzysdz
left a comment
krzysdz
left a comment
There was a problem hiding this comment.
Typo in file extension (.ym instead of .yml).
Phillip9587
left a comment
Phillip9587
left a comment
There was a problem hiding this comment.
Just 2 small questions but LGTM
| uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 | ||
| with: | ||
| node-version: "lts/*" | ||
| registry-url: "https://registry.npmjs.org" |
There was a problem hiding this comment.
Probably yes. That's what actions/setup-node docs show.
It has something to do with auth: actions/setup-node#21 (comment)
Iff registry-url is set actions/setup-node creates an .npmrc file with the auth token (set to ${NODE_AUTH_TOKEN}).
| # npm stage publish requires npm >= 11.15.0 | ||
| - name: Upgrade npm | ||
| run: npm install -g npm@latest | ||
|
|
There was a problem hiding this comment.
I think the lts/* alias already resolves to the latest Node.js 24 with an npm version >11.15.0. So this is only a safeguard?
|
Is it possible to trigger a v1 release with the release trigger? All release workflows i used an for example the workflows added by Blake in jshttp use a tag pattern as trigger. |
🤦 I missed this comment, I will push a change on the target branch |
|
Corrected in d4d0a5b |
3 participants
Port the same release process as multer: expressjs/multer#1364