fix: add SSL mode support to MySQL/MariaDB connections (#36505) - #1534
Open
hidekoji wants to merge 3 commits into
Open
fix: add SSL mode support to MySQL/MariaDB connections (#36505)#1534hidekoji wants to merge 3 commits into
hidekoji wants to merge 3 commits into
Conversation
hidekoji
commented
Jul 2, 2026
hidekoji
marked this pull request as ready for review
July 2, 2026 06:42
kei51e
approved these changes
Jul 2, 2026
- Add sslMode param to queryMySQL (default "") - Wire sslMode through executeGenericQuery → queryMySQL - Add sslMode to getDBConnection/clearDBConnection cache key for mysql/aurora - Map PostgreSQL-style SSL mode strings to RMariaDB constants (SSL_MODE_*) - Refactor mysql/aurora connection creation to do.call for clean conditional args
hidekoji
force-pushed
the
fix/issue-36505
branch
from
August 28, 2026 16:39
e81b989 to
cfd997e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds MySQL/MariaDB SSL mode handling for Exploratory issue #36505.
Changes
sslModethroughqueryMySQL,executeGenericQuery,getDBConnection,clearDBConnection, and the column-listing error path.client.flagvalues instead of the unsupportedssl.modeargument:disable: no SSL client flag and no CA argumentallow/prefer: default client behavior with the configured CArequire/verify-ca:CLIENT_SSLwith the configured CAverify-full:CLIENT_SSL+CLIENT_SSL_VERIFY_SERVER_CERTwith the configured CARMariaDB does not expose a separate CA-only client flag, so
verify-causes the supportedCLIENT_SSL+ssl.cacombination.Tests
git diff --check.