Rename static helpers that collide with user names - #853
Open
sueszli wants to merge 2 commits into
Open
Conversation
sueszli
force-pushed
the
fix/static-helper-name-collisions
branch
from
August 30, 2026 13:07
25d9dfe to
125bcc0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
==========================================
+ Coverage 88.56% 88.58% +0.02%
==========================================
Files 100 100
Lines 21917 21934 +17
==========================================
+ Hits 19410 19430 +20
+ Misses 2507 2504 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sueszli
force-pushed
the
fix/static-helper-name-collisions
branch
from
September 1, 2026 21:59
125bcc0 to
64fd322
Compare
The helpers in _static_helpers are pasted at file scope in the generated C, so a proc or a proc argument can take a helper name. A proc named exo_floor_div produced "static declaration of 'exo_floor_div' follows non-static declaration", and an argument of that name produced "called object type 'int_fast32_t' is not a function or function pointer". Rename a helper when a proc takes its name, and reserve helper names in each proc so that an argument is renamed instead. A renamed argument also avoids proc names so it cannot shadow a proc it calls.
sueszli
force-pushed
the
fix/static-helper-name-collisions
branch
from
September 2, 2026 21:43
64fd322 to
52f5cf0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This patch is very low priority
Actual:
Expected: