Use floor modulo for % in generated C - #852
Open
sueszli wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #852 +/- ##
=======================================
Coverage 88.56% 88.56%
=======================================
Files 100 100
Lines 21917 21926 +9
=======================================
+ Hits 19410 19419 +9
Misses 2507 2507 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sueszli
force-pushed
the
fix/floor-mod-codegen
branch
from
September 1, 2026 21:59
fb88c5e to
b046038
Compare
Bounds checking treats % as floor modulo and proves that i % 5 lies in [0, 5). C truncates toward zero, so a negative numerator produced a negative index and an accepted proc wrote out of bounds. Route % through a floor modulo helper when the numerator is not provably non-negative, matching how / already routes through exo_floor_div.
sueszli
force-pushed
the
fix/floor-mod-codegen
branch
from
September 2, 2026 21:43
b046038 to
0e511a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actual:
Called with
i = -1this writesdst[-1]. ASan reportsstack-buffer-underflow, WRITE of size 4.Expected:
Bounds checking treats
%as floor modulo, so it proves thati % 5lies in[0, 5). C truncates toward zero instead. Division already routes throughexo_floor_divfor the same reason. Modulo did not.