Skip to content

Adds Neon ISA example - #695

Open
rtzam wants to merge 4 commits into
mainfrom
neon-example
Open

Adds Neon ISA example#695
rtzam wants to merge 4 commits into
mainfrom
neon-example

Conversation

@rtzam

@rtzam rtzam commented Aug 23, 2024

Copy link
Copy Markdown
Contributor

This CL adds the Neon equivalent
of the x86-AVX example. It changes
the Makefile to build the neon
example. It also modifies
the provided main.c file
to work for either the
generated neon or avx code

This CL adds the Neon equivalent
of the x86-AVX example. It changes
the Makefile to build the neon
example. It also modifies
the provided main.c file
to work for either the
generated neon or avx code
@rtzam
rtzam requested a review from yamaguchi1024 August 23, 2024 20:57
@yamaguchi1024

Copy link
Copy Markdown
Member

We probably need to clean up the Python code and modify the readme to point to the Neon example. I think we should merge the documentation / tutorial changes at once.

@codecov

codecov Bot commented Aug 28, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.78%. Comparing base (37dc108) to head (672a2ac).
⚠️ Report is 76 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #695   +/-   ##
=======================================
  Coverage   87.78%   87.78%           
=======================================
  Files          84       84           
  Lines       20721    20721           
=======================================
  Hits        18190    18190           
  Misses       2531     2531           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gilbo

gilbo commented Sep 3, 2024

Copy link
Copy Markdown
Contributor

The README.md file is out of sync with the code. Let's discuss a path to getting this committed ASAP in person. I can share an optional code rewrite with some alternate comments as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants