Harden NAS cleanup integrity - #28
Merged
Merged
Conversation
Release-asset naming: per-OS installers are now named
ExLabWizard_v<release-tag>.<ext> (e.g. ExLabWizard_v0.2.0.exe/.dmg/.AppImage).
The name is driven by the release tag with a leading v/V normalised, so both
v0.2.0 and 0.2.0 produce ExLabWizard_v0.2.0 (never _vv0.2.0). Non-release
builds (dispatch/PR) fall back to the package __version__. Raw onedir archives
keep an OS suffix (ExLabWizard_v<tag>-<suffix>.{zip,tar.gz}) because macOS and
Linux both emit .tar.gz and would otherwise collide as release assets. The
Inno .iss takes a /DOutputBaseName define; upload + release globs updated to
ExLabWizard_v*.
Pre-releases: the `published` activity type already fires for pre-releases, so
publishing a pre-release builds + attaches the full installer set (test an RC
before shipping). No trigger change; documented in the workflow header.
Pre-releases do NOT notify: the startup checker polls releases/latest, which
GitHub defines as the most recent non-prerelease, non-draft release -- so a
pre-release never prompts an upgrade. Added a defensive guard in
fetch_latest_tag (skip payloads flagged prerelease/draft) + two unit tests so
the requirement is encoded in our code, not just implied by the endpoint.
README updated for the new asset names and the pre-release behaviour.
Tag-name input is routed through env (not interpolated into the run body) to
avoid shell injection.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add exact cleanup candidate planning, delete-only cleanup, ignored-file retention by default, explicit cleanup deferral reasons, and tests. Also stop tracking graphify-out artifacts now that the directory is ignored.
# Conflicts: # tests/unit/sync/test_nas_client.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nas_cleanup.delete_ignoredfor explicit discard behavior.graphify-outartifacts.Test Plan
uv run pytest tests/unit/sync/test_run_delete.py -quv run pytest tests/unit/sync/test_nas_client_extra.py -quv run pytest tests/unit/sync/test_cleanup.py -quv run pytest tests/unit/config/test_models.py -quv run pytest tests/unit/sync tests/unit/orchestrator/test_quiescence_poller.py tests/integration/test_nas_sync.py -quv run ruff check src/exlab_wizard/sync src/exlab_wizard/config tests/unit/sync tests/unit/configuv run mypy src/exlab_wizard/sync src/exlab_wizard/config