[Update exercise] Crypto Square - #539
Merged
Merged
Conversation
Contributor
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
Contributor
Author
|
There are 108 completions, so retesting should be reasonable. |
depial
approved these changes
Aug 5, 2026
Contributor
|
A bit odd that it erred with |
Contributor
Author
|
My fault: sloppy copy-paste. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I solved this exercise in R yesterday, in preparation for adding it to Julia and Fortran. Turns out, the 8-year-old implementation diverges a lot from canonical data: over-complicated, restrictive and really quite annoying.
I've added a template, updated tests to the current problem specification, and removed all functions except
ciphertext().This should give students more freedom to explore different approaches. I don't think it breaks existing solutions, it just ignores big chunks of code.