build: update Nextcloud webpack toolchain - #103
Merged
Conversation
Contributor
Preview this PR in the Nextcloud PlaygroundA fresh Nextcloud boots in your browser with this branch's eXeLearning editor: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@nextcloud/webpack-vue-configfrom 7.0.2 to 7.0.4sass-loaderpeer from 16 to 17terser-webpack-pluginwithminimizer-webpack-plugin^22.15.0 || ^24.0.0package-lock.jsonWhy
Dependabot PR #101 updated only
@nextcloud/webpack-vue-config. Version 7.0.4 requiressass-loader ^17.0.0, while the app still declaredsass-loader ^16.0.2, so every job that rannpm cifailed withERESOLVEbefore frontend checks could start.The updated toolchain also brings
webpack-dev-server 6, whose minimum Node.js version is 22.15. This PR removes the no-longer-valid Node 20 claim while preserving the Node 22 line currently used by CI and Node 24 support.This supersedes #101 with the complete, resolvable dependency update.
Impact
This affects development and asset compilation only. The Nextcloud app runtime does not require Node.js. Developers building assets now need Node.js 22.15+ on the Node 22 line, or Node.js 24.
Validation
composer installnpm installnpm cinpm run typechecknpm run lintnpm test— 108 tests passedmake architecture-checkmake architecture-testnpm run buildvendor/bin/phpunit --configuration tests/phpunit.xml— 37 tests, 75 assertionsmake -n download-editor fetch-editor-source build-editor clean-editor build dev lint typecheckgit diff --checkLocal npm commands emitted expected
EBADENGINEwarnings because the local machine runs unsupported Node.js 26; dependency resolution, tests, and the production build completed successfully.