馃悰 fix(npm): allow deprecated node10 resolution under TypeScript 6 - #58
Merged
Conversation
npm/zevm/package.json declares typescript ^6.0.3, but tsconfig.cjs.json sets moduleResolution=Node (node10), which TypeScript 6 reports as error TS5107. That breaks `pnpm --filter @evmts/zevm build` and, because tevm consumes this package as a pnpm workspace member, it breaks tevm's CI too. The CJS build genuinely needs node10 resolution to emit CommonJS, so silence the deprecation explicitly as the compiler suggests rather than changing the module strategy. Verified: tsc -p tsconfig.cjs.json --noEmit passes under typescript 6.0.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm/zevm/package.jsondeclarestypescript@^6.0.3, buttsconfig.cjs.jsonsetsmoduleResolution: Node(node10), which TypeScript 6 now reports as a hard error:This breaks
pnpm --filter @evmts/zevm build. It also breaks tevm's CI, because tevm includes../zevm/npm/zevmas a pnpm workspace member and builds it during setup.The CJS build legitimately needs node10 resolution in order to emit CommonJS, so this silences the deprecation exactly as the compiler recommends rather than restructuring the module strategy (which should be a deliberate, separate change before TS 7).
Verified:
tsc -p tsconfig.cjs.json --noEmitpasses undertypescript@6.0.3.馃 Generated with Smithers multi-agent orchestration