fix(fetchers): validate Crossref API policy#169
Open
chaliy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
https://api.crossref.org/works/...URL and dispatched it to the transport without applying the configured egress policy, allowingblocked_hostsorallowed_portsto be bypassed.api.crossref.org:443when operators have blocked that host or disallowed that port.Description
options.validate_url(&api_url)?;before callingtransport_requestincrates/fetchkit/src/fetchers/crossref.rs.blocks_crossref_api_host_policy_before_transportandblocks_crossref_api_port_policy_before_transportto ensure blocked host and disallowed port policies causeFetchError::BlockedUrlfor DOI requests.api.crossref.org:443.Testing
cargo test -p fetchkit crossref --liband the new Crossref tests passed.cargo test --workspaceand all workspace tests passed (no failures).cargo fmt --all -- --checkandcargo clippy --workspace --all-targets -- -D warningsand both checks passed.Codex Task