fix(fetchers): enforce policy for API subrequests#167
Open
chaliy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
https://api.github.combuilt by the GitHub Actions run fetcher.Description
validate_policy_url(url: &Url, options: &FetchOptions)helper incrates/fetchkit/src/fetchers/mod.rsthat enforcesFetchOptions::validate_urlplus allow/block prefix checks viaurl_matches_policy_prefix.validate_policy_urlwhen finding a matching fetcher.validate_policy_urlat the start oftransport_requestincrates/fetchkit/src/fetchers/default.rsso specialized fetchers must pass policy validation before the transport executes any secondary API request.enforces_policy_on_api_requests_before_transportincrates/fetchkit/src/fetchers/github_actions_run.rsthat asserts API subrequests are blocked withFetchError::BlockedUrlbefore transport execution.Testing
fetchers::github_actions_run::tests::enforces_policy_on_api_requests_before_transport, which passed.cargo test -p fetchkitandcargo test --workspace, both of which completed with all tests passing.cargo clippy --workspace --all-targets -- -D warnings,cargo fmt --all,RUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps, andcargo build --workspace --exclude fetchkit-python --release, and all checks completed successfully.Codex Task