Release v0.7.8 - #64
Merged
Merged
Conversation
The git-cliff-action outputs `content` (changelog text) and `changelog` (file path). The workflow was reading the file path instead of the text, causing the fallback to GitHub auto-generated release notes. Fixes: .outputs.changelog → .outputs.content in set_output step.
- Add openairclim==0.13.0 to dependencies with uv git source - Pin pybada==0.1.10 in Makefile (kept manual install due to requires-python conflict) - Remove manual pip install of openairclim from Makefile - Bump requires-python to >=3.11.5 (openairclim constraint)
…M-628] Replace all 11 occurrences of self.default_params.xxx with self.params.xxx in OpenAirClimModel.run() and _flight_to_inventory(). self.default_params is the class-level type (OpenAirClimParams), not the instance-resolved params set by BaseStep.__init__. This caused all runtime parameter injection to be silently ignored — in particular tmp_base_dir_path was always '' (class default), causing tempfile.TemporaryDirectory(dir='') to create relative tmp dirs that fail on read-only filesystems (Azure). Also updates test_tmpdir_bugs.py to mirror the fixed pattern and assert correct behavior instead of documenting the bug.
Add 5 unit tests validating that BaseStep subclasses correctly use self.params (instance-resolved) instead of self.default_params (class defaults) for runtime parameters like tmp_base_dir_path. These tests are self-contained and do not require pycontrails, openairclim, or pyBADA. Ref: AXM-628
climACCF is not used by the project. Replace the dependency version field in FleetReport with openAirClim, which is the actual climate function library in use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
🐛 Bug Fixes
self.paramsinstead ofself.default_params— the model was ignoring instance parameters and always falling back to class defaults ([AXM-628])♻️ Changed
climaccf_versionwithopenairclim_versionin climate metrics JSON output (climACCFis no longer used directly)🧪 Testing
self.paramsfix📦 Dependencies
openairclimas formal dependencypybadaversion📚 Documentation
CHANGELOG.mdwith git-cliff (full commit history)