Skip to content

fix filename sanitization for directory names - #116

Open
ShivamSingh47007 wants to merge 1 commit into
ethereal-developers:masterfrom
ShivamSingh47007:master
Open

fix filename sanitization for directory names#116
ShivamSingh47007 wants to merge 1 commit into
ethereal-developers:masterfrom
ShivamSingh47007:master

Conversation

@ShivamSingh47007

Copy link
Copy Markdown

issue (#113)
I created a pull request that replaces : with - in the generated directory name.
This should prevent filename issues when exporting files to Nextcloud.

the directory name was created using DateTime.now() which includes : characters

this change replaces : with - when creating the directory name

this helps avoid filename issues when exporting files to Nextcloud and other file systems

@veejayts
veejayts self-requested a review August 23, 2026 09:49
@veejayts veejayts linked an issue Aug 23, 2026 that may be closed by this pull request
@veejayts

Copy link
Copy Markdown
Member

Hi Shivam, thanks for volunteering to fix this issue.

I think the file name would be better if it the output was in the following format OpenScan-2026-08-23-1787479053634 since it is cleaner and avoid any other characters like period that the current file name generates.

OpenScan-yyyy-mm-dd-millisecondsSinceEpoch

If it is changed to that, I can sanity test it once and merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default file name contains illegal characters

2 participants