Reformat markdown for ruff 0.16 and pin ruff in CI - #14
Open
gomezzz wants to merge 1 commit into
Open
Conversation
ruff 0.16 started formatting fenced code blocks inside Markdown, so 'ruff format --check .' fails on pre-existing docs files and turns the lint job red on every pull request. Pin the action to 0.16.0 as well. It otherwise resolves to the latest release, so a future ruff can break CI on unchanged code the same way.
Coverage Report (build + browser)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ruff format --check .fails on pre-existing docs files. That turns thelintjob red on every pull request, including the contribution-guidelines PR.astral-sh/ruff-action@v3to0.16.0. The action otherwise resolves to whatever ruff is newest, so an upstream release can fail CI on unchanged code, which is exactly what happened here.Scope
Markdown only, no Python touched. Every hunk is inside a ```python fence: quote normalisation, magic trailing commas, comment realignment, line rewrapping. No documented API, argument, or value changed.
Verified locally
uvx ruff@0.16.0 format --check .cleancheck_license_headersjob compares them byte for byte)Test plan
lintgreencheck_license_headersgreen