interfaces/apparmor: don't panic when preparing devmode profiles - #8
Open
ernestl wants to merge 1 commit into
Open
interfaces/apparmor: don't panic when preparing devmode profiles#8ernestl wants to merge 1 commit into
ernestl wants to merge 1 commit into
Conversation
The leftover security-release panic was only meant to exist on the 2.54.3 branch. Remember core/snapd when those snaps are set up, and fall back to the host snap-confine profile when neither is known yet. Co-authored-by: Ernest Lotter <ernest.lotter@gmail.com>
ernestl
marked this pull request as ready for review
September 1, 2026 07:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?
The leftover
panic()in the AppArmor backend was a 2.54.3 security-release workaround for UC16 first-boot seeding with a devmode snap in the seed. The comment said it would be removed or adapted before landing on master, but it stayed.This change:
/usr/lib/snapd/snap-confineprofile when neither snap is known yet, matching the core-only case. This also covers classic systems that only have the distro package.The old panic test is replaced with coverage for the fallback and for remembering core after it is set up.