tests and refactorings for drifting_ships - #1158
Merged
Merged
Conversation
export drifting_ships() so it can be tested upgrade code style forand rename old drift_target test add new test, not doing much yet.
drifting sets the SF_DRIFTING flag drifting sets the SF_FISHING flag
Added MIN and MAX macro needed for testing
ennorehling
changed the title
ennorehling
changed the title
ennorehling
added a commit
that referenced
this pull request
Sep 4, 2026
* refactor drifting ships export drifting_ships() so it can be tested upgrade code style forand rename old drift_target test add new test, not doing much yet. * test: drifting ships cannot fish drifting sets the SF_DRIFTING flag drifting sets the SF_FISHING flag * test: ships drift to nearby region * test: under-crewed ship gets correct message * delete old debug tests * refactor: extract drift_reason Added MIN and MAX macro needed for testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function had little to no test coverage, adding some.