[PLAT-5055] Add with_valkey_glide option to PHP CI workflows - #157
Merged
Conversation
…low input Centralize valkey_glide pecl install for PHP CI workflows. Adds optional with_valkey_glide on php-stan, php-cs-fixer, and php-laravel-test. Co-authored-by: Cursor <cursoragent@cursor.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Local `./` action paths resolve against the caller's checkout in workflow_call workflows, so cross-repo callers setting with_valkey_glide failed with "Can't find action.yml". Reference the composite via its fully-qualified encodium/.github path so it resolves regardless of the caller's checked-out repo. Ref pinned to the PLAT-5055 branch for pre-merge testing; must be switched to @main before merge. Co-authored-by: Cursor <cursoragent@cursor.com>
Use the stable main ref instead of the feature branch so merged workflows do not depend on a temporary branch name. Co-authored-by: Cursor <cursoragent@cursor.com>
Pipe empty responses into pecl install so configure prompts such as enable-valkey-glide-debug do not block CI jobs waiting for stdin. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d43f78a. Configure here.
With pipefail enabled, yes exits 141 when pecl closes stdin after a successful install. Treat that exit code as success so the step does not fail after valkey_glide is installed. Co-authored-by: Cursor <cursoragent@cursor.com>
aspencer
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install-valkey-glidecomposite action for CI runnerswith_valkey_glideinput tophp-stan,php-cs-fixer, andphp-laravel-testreusable workflowsphp-stanPackagist auth by moving credentials toCOMPOSER_AUTHoncomposer-installgithub.head_refcheckout override fromphp-cs-fixer(breaks fork PRs; lint-only workflows do not need it)https://revolutionparts.atlassian.net/browse/PLAT-5055
Test plan
@PLAT-5055-valkey-glide-cirefs@mainand re-run CIMade with Cursor