Fix site metadata - #37
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves correctness/observability around run-level handling and stabilizes metadata-related tests, while also documenting and introducing a configuration knob for random identifier size.
Changes:
- Added a new public
classy:run_level/0API and adjusted run-level counter updates to reflect the “next” level before running run-level hooks. - Reduced test flakiness by replacing fixed sleeps with retries and adding assertions around run-level transitions.
- Made random ID length configurable via
rand_id_bytesand documented the new configuration option.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/classy_SUITE.erl | Stabilizes metadata/run-level tests via retries and additional run-level hook assertions. |
| src/classy.erl | Exposes a new run_level/0 getter API. |
| src/classy_rl_changer.erl | Refactors counter updates and updates “current” before run-level hooks execute. |
| src/classy_node.erl | Makes random ID byte-length configurable when initializing site/cluster IDs. |
| doc/classy.texi | Documents the new rand_id_bytes configuration setting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Streamline mechanism used when node leaves the cluster (by kicking self). Now it doesn't rely on the eventsfrom membership CRDT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.