Upstream float support for inRange - #347
Open
martin4861 wants to merge 2 commits into
Open
Conversation
martin4861
force-pushed
the
upstream-float-support
branch
from
August 6, 2026 09:04
b72e140 to
39ba1cf
Compare
martin4861
force-pushed
the
upstream-float-support
branch
from
August 6, 2026 09:13
7b0f806 to
f9302e2
Compare
martin4861
marked this pull request as ready for review
August 6, 2026 10:56
Author
|
@emil-e would you be able to perform a review of this PR? Thanks a lot in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstreaming our patches for float support:
inRangeinto an overloaded function for floating values inNumeric.hpp. Floating values cannot use an integer modulo.floatspecialization toTowardsSeqinShrink.hpp. The integral version ofTowardsSequsesstd::make_unsigned, which is unavailable for floating values.I tested with gcc-11 (therefore I had to temporarily update
ext/catchtov2.13.10)