Packaging: vendor the runtime packs each Ubuntu series asks for - #73
Merged
Conversation
Launchpad builders have no network, so the source package carries the NuGet feed the publish needs. That feed was vendored with this desk's SDK alone, which asks for the runtime packs of the runtime it bundles; noble's builder bundles an older one and failed the restore with NU1102 before compiling anything. The script now downloads the packs for every version in the list as well, and PPA_SUFFIX raises the series suffix so a rebuild of the same upstream version is a version Launchpad accepts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.1.31 noble build failed with NU1102: the vendored feed had the 10.0.12 runtime packs from this desk's SDK, while noble's SDK pins 10.0.11 and the builders have no network. Resolute, whose SDK matches, built fine.
make-source.shnow also downloads the runtime, host and ASP.NET packs for every version inPPA_RUNTIME_PACKS(10.0.11 and 10.0.12 today) into the same folder the feed is laid out from, so each series finds what its SDK asks for.PPA_SUFFIXsets the series suffix, which a rebuild of an already uploaded version needs, and the usage note says the first argument is a git ref.Verified the download layout locally: the packs land with their .nupkg, .nupkg.sha512 and .nuspec, which is what the feed loop copies.