refactor: extract version check to bash script, remove Python from release.yml (s0.16) - #56
Merged
Merged
Conversation
Replace inline Python version guard in release.yml with a bash script that reads the workspace version from Cargo.toml (one grep, no Python). Add check-version justfile recipe for local debugging. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/check-version.sh— reads workspace version fromCargo.tomlwith grep (no Python)release.ymlwithbash scripts/check-version.shcheck-versionjustfile recipe for local debuggingTest plan
RELEASE_VERSION=v0.1.0 bash scripts/check-version.sh→Version check OK: 0.1.0RELEASE_VERSION=v0.2.0 bash scripts/check-version.sh→ clear errorpython3inrelease.ymljust cipasses🤖 Generated with Claude Code