Simplify os_description trim; rebase on main

[dominicletz]

Summary

• Rebased onto main (PR Add Platform.System.os_description/0 #74 already merged)
• Simplified nested case in Desktop.Platform.System.os_description/0 to if raw do … end (Gemini feedback)
• Removed no-op Process.delete/1 from on_exit in platform_system_test.exs (cleanup runs in a separate process)

Test plan

• mix test test/desktop/platform_system_test.exs test/desktop/backend/json_test.exs test/desktop/backend/browser_test.exs test/desktop/regression/beam_wx_calls_test.exs --exclude wx
• mix test.guard
• xvfb-run -a mix test test/desktop/backend/wx_test.exs --only wx

  

[gemini-code-assist]

Code Review

This pull request introduces Desktop.Platform.System.os_description/0 as a backend-safe replacement for :wx_misc.getOsDescription/0, implementing it across the Browser, Json, and Wx backends along with corresponding tests. Feedback suggests simplifying the nested case statements in os_description/0 for better readability, and removing a redundant Process.delete/1 call inside the test's on_exit/1 callback since it runs in a separate process.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

The nested case statements can be simplified to a single if block, which improves readability and is more idiomatic Elixir.

    if raw do
      case String.trim(raw) do
        "" -> nil
        trimmed -> trimmed
      end
    end

[gemini-code-assist]

In ExUnit, on_exit/1 callbacks run in a separate process, not the test process. Therefore, calling Process.delete(:stub_os_description) inside on_exit is a no-op as it deletes the key from the cleanup process's dictionary rather than the test process's dictionary. Since the test process terminates and its process dictionary is automatically garbage collected, you can safely remove this line.

    on_exit(fn ->
      Application.put_env(:desktop, :backend, previous)
    end)

[dominicletz]

@cursoragent rebase this on master and fix the gemini comments

[cursor]

Rebased onto main and addressed both Gemini notes on #75:

• os_description/0 now uses a single if raw do … end for blank trimming
• Removed the no-op Process.delete/1 from on_exit

Related tests, guards, and wx tests passed.