Skip to content

Cleanup: FolderManager File object#1770

Open
jeremypw wants to merge 5 commits into
masterfrom
jeremypw/foldermanager/file-cleanup
Open

Cleanup: FolderManager File object#1770
jeremypw wants to merge 5 commits into
masterfrom
jeremypw/foldermanager/file-cleanup

Conversation

@jeremypw

@jeremypw jeremypw commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator
  • Inline namespace
  • Inline single use functions
  • Reorder to static, public, private members, create, construct, public methods, private methods
  • Make path construct only
  • Set GLib.File only in construct clause
  • Load info on construct, including executable attribute
  • Start to make naming less ambiguous

* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
* Authored by: Julien Spautz <spautz.julien@gmail.com>, Andrei-Costin Zisu <matzipan@gmail.com>
* Copyright (c) 2017-2025 elementary LLC. (https://elementary.io),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're messing with the header can we make it a SPDX header?

}
// returns the path the file
public string path { get; construct; }
public GLib.File file { get; private set; }

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to watch for file path changes? Was this perhaps the way it was before to account for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants