clerk-tools: unify toolset dispatch, add carving/tinkering support - #7521
Open
simtel12 wants to merge 2 commits into
Open
clerk-tools: unify toolset dispatch, add carving/tinkering support#7521simtel12 wants to merge 2 commits into
simtel12 wants to merge 2 commits into
Conversation
Replaces the elsif chain with a TOOLSETS table, so adding a discipline means adding an entry rather than another branch. Legacy names (forging, outfitting, engineering, alchemy, enchanting) keep working unchanged via a LEGACY_TOOLSETS alias map. Adds carving and tinkering as toolsets clerk-tools can get/store, which it previously had no support for at all. Their belt resolution follows the same carving_belt/tinkering_belt || engineering_belt fallback (elanthia-online#1420) that carve.lic, carve-bead.lic, carve-lockpicks.lic, tinker.lic, and bolts.lic already use, so tools land where those scripts expect to find them. Documents the previously-undocumented carving_tools/tinkering_tools settings in data/base-help.yaml.
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
taskmaster.lic already reads shaping_tools for lumber-task repairs, same as workorders.lic; it was just missing from the help entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clerk-tools.lic'selsifchain with aTOOLSETStable, so adding a discipline means adding an entry rather than another branch. Legacy names (forging,outfitting,engineering,alchemy,enchanting) keep working unchanged via aLEGACY_TOOLSETSalias map.carvingandtinkeringas toolsets clerk-tools can get/store — it previously had no support for either. Belt resolution follows the samecarving_belt/tinkering_belt || engineering_beltfallback (Crafting belts, need more categories #1420) thatcarve.lic,carve-bead.lic,carve-lockpicks.lic,tinker.lic, andbolts.licalready use, so tools land where those scripts expect to find them.carving_tools/tinkering_toolssettings indata/base-help.yaml(already read bycarve.licandworkorders.lic, just never had help entries).Test plan
rspec spec/clerk_tools_spec.rbpasses (27 examples, 0 failures), including new coverage for thecarving_belt/tinkering_beltoverride and fallback behaviorrspecsuite passes (2837 examples, 0 failures)ruby -c clerk-tools.licsyntax check cleanrubocop clerk-tools.licclean