feat: rm juggler/gaudi - #377
Open
wdconinc wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes Gaudi/Juggler-related components from the EIC container Spack environments and strips associated build-time override plumbing from CI/build scripts and documentation, reflecting that these packages are no longer intended to be part of the supported software stack.
Changes:
- Remove
gaudiandjuggler(and related entries) from multiple Spack environment spec lists (xl,cuda,prod,cvmfs,ci_without_acts, and EPIC subenvs). - Remove Juggler-specific version override variables/inputs (
JUGGLER_VERSION,JUGGLER_SHA) from build scripts, Dockerfile, and CI workflows. - Update documentation to stop referencing Juggler overrides and package presence.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| spack-environment/xl/spack.yaml | Drops Gaudi and Key4HEP-related specs from the XL environment list. |
| spack-environment/xl/epic/spack.yaml | Removes juggler from the EPIC subenvironment specs (XL). |
| spack-environment/prod/spack.yaml | Drops gaudi from the production environment specs. |
| spack-environment/prod/epic/spack.yaml | Removes juggler from the EPIC subenvironment specs (prod). |
| spack-environment/cvmfs/spack.yaml | Drops gaudi from the CVMFS environment specs. |
| spack-environment/cvmfs/epic/spack.yaml | Removes juggler from the EPIC subenvironment specs (cvmfs). |
| spack-environment/cuda/spack.yaml | Drops Gaudi and Key4HEP-related specs from the CUDA environment list. |
| spack-environment/cuda/epic/spack.yaml | Removes juggler from the EPIC subenvironment specs (CUDA). |
| spack-environment/ci_without_acts/spack.yaml | Drops gaudi from the CI-without-ACTS environment specs. |
| scripts/build-eic.sh | Removes resolving/passing JUGGLER_SHA as a build arg. |
| docs/spack-environment.md | Removes mentions of juggler from environment examples and package lists. |
| docs/building-locally.md | Removes JUGGLER_SHA from the documented local-build override args. |
| containers/eic/Dockerfile | Removes ARG JUGGLER_SHA and the logic that rewrote packages.yaml to pin juggler. |
| .gitlab-ci.yml | Removes JUGGLER_VERSION CI variable. |
| .github/workflows/build-push.yml | Removes workflow_dispatch input and env wiring for JUGGLER_VERSION. |
wdconinc
enabled auto-merge (squash)
August 3, 2026 16:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR removes
jugglerandgaudifrom the software stack. It is now not used anymore by anything. We also don't need explicitk4actstrackingandk4fwcoreanymore. We keep the restrictions insidepackages.yamlsince people may still want to install these packages in their local environments, and the minimum versions still apply.What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply