Fix new-installer upstream fallback for eic-shell installs - #370
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
@kkauder PTAL (after container build) |
|
Actually, I'm now surprised this isn't in v1.2.1 yet. Which docker container are you using, @kkauder? |
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s pinned Spack source by adding a new upstream Spack cherry-pick to fix eic-shell failures when using the new installer with missing/partial upstreams, aligning behavior with the upstream resolution instead of relying on the legacy installer workaround.
Changes:
- Add Spack commit
913c85673a3ce076ef905489826d3f9d8adb7e54toSPACK_CHERRYPICKSinspack.sh. - Add the corresponding
## [hash]: [description]annotation documenting the cherry-pick’s purpose.
How do I find out? No older than ten days but I also --upgraded it a few days ago.
|
Line 8 in d86c564 So it's on v1.2.1. |
Spack installs inside
eic-shellwere failing in finalization with the new installer, whileconfig:installer:oldworked as a workaround. This updates our Spack cherry-picks to take the upstream fix path instead of forcing the legacy installer.This change adds the merged upstream fix commit from
spack/spackPR #52630 toSPACK_CHERRYPICKSinspack.sh, with the corresponding annotation:913c85673a3ce076ef905489826d3f9d8adb7e54(new_installer.py: allow local install if missing upstream)This keeps the new installer enabled and aligns container behavior with the upstream resolution for missing-upstream install handling.
Fixes: #369