Revert "fix: install node for data engineering jenkins" - #364
Merged
amits-2u merged 1 commit intoAug 4, 2026
Merged
Conversation
This reverts commit 5985041.
There was a problem hiding this comment.
Pull request overview
This PR reverts the changes from #363 that installed Node.js (via NodeSource) as part of the jenkins_data_engineering_new role, returning the Jenkins data engineering host provisioning to its prior behavior.
Changes:
- Removed NodeSource GPG key installation, apt repository configuration, and Node.js package installation steps from the role tasks.
- Removed the
JENKINS_DATA_ENGINEERING_NODE_VERSIONdefault variable from the role defaults.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| playbooks/roles/jenkins_data_engineering_new/tasks/main.yml | Removes the NodeSource/Node.js installation tasks that were added in the reverted PR. |
| playbooks/roles/jenkins_data_engineering_new/defaults/main.yml | Removes the default Node.js version variable introduced for the NodeSource repo setup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
amits-2u
approved these changes
Aug 4, 2026
amits-2u
deleted the
revert-363-rahul/install-node-for-de-jenkins-health-check
branch
August 4, 2026 07:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #363