Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Gunicorn configuration used by commerce-coordinator to better handle Datadog DogStatsD endpoint configuration, specifically preserving unix://... URLs when DD_DOGSTATSD_URL points at a Unix domain socket.
Changes:
- Adds explicit handling for
DD_DOGSTATSD_URLvalues starting withunix://so the socket URL is passed through as-is. - Retains existing behavior for
udp://...endpoints by stripping the scheme to match Gunicorn’s expectedHOST:PORTformat.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
commerce_coordinator/docker_gunicorn_configuration.py:21
- The unix-socket branch only treats the exact string "unix://" as invalid, but values like "unix:///" (no path) or "unix://path" (missing the third slash) would still be forwarded to Gunicorn even though the comment says the expected form is "unix:///path". Consider normalizing/validating the URL so you only set statsd_host when a non-empty socket path is present, and rewrite "unix://" to "unix:///" for consistency.
if _dogstatsd_url.startswith("unix://"):
# Gunicorn accepts unix socket directly as "unix:///path".
_statsd_host = _dogstatsd_url if _dogstatsd_url != "unix://" else ""
else:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes GSRE-3388
Updates Gunicorn StatsD configuration to preserve unix:// DogStatsD URLs.This prevents invalid socket configuration when DD_DOGSTATSD_URL is set to a Unix socket path and should resolve StatsD transport errors caused by the previous parsing logic
Merge checklist:
Check off if complete or not applicable:
Post-merge: