Skip to content

refactor(debt): reduce actionable CLI and site findings - #49

Merged
eduardbar merged 3 commits into
masterfrom
refactor/debt-site-production
Aug 3, 2026
Merged

refactor(debt): reduce actionable CLI and site findings#49
eduardbar merged 3 commits into
masterfrom
refactor/debt-site-production

Conversation

@eduardbar

Copy link
Copy Markdown
Owner

Refs #42

Summary

  • Remove one dead guard export while preserving guard output and exit behavior.
  • Reduce real site debt in App.jsx and HeaderHero.jsx through semantic constants and presentational decomposition.
  • Add SSR/browser-backed hero contract coverage for links, anchors, proof points, metrics, and GSAP hooks.

Evidence

  • App findings: 21 -> 11
  • Site total: 38 -> 29
  • Guard dead export removed; no new findings
  • Root/site builds pass
  • SSR tests and browser render pass with zero console errors/warnings
  • No analyzer rule, weight, severity, or exclusion changes

Notes

Residual JSX
o-return-type findings remain explicit because adding TypeScript return annotations would require a separate TSX migration. Benchmark fixtures remain visible and unchanged.

@eduardbar eduardbar added the type:quality Quality gates and testing label Aug 3, 2026
@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
site Ready Ready Preview Aug 3, 2026 9:01pm

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

drift trust

drift trust

  • Trust Score: 48/100
  • Merge Risk: HIGH
  • Target: /home/runner/work/drift/drift

Diff signals

  • Base ref: origin/master
  • Diff status: REGRESSED
  • Score delta: +0
  • Issues: +14 new / -24 resolved
  • Trust adjustment: +30 penalty / -20 bonus (net +10)

Top reasons

  • Error-level issues: 8 error issue(s) increase merge volatility. (impact 22)
  • Highest-risk file: /home/runner/work/drift/drift/site/src/App.jsx has hotspot risk 70/100. (impact 11)
  • Diff regression signals: Against origin/master: score delta +0, +14 new issue(s), -24 resolved. (impact 10)
  • Maintenance hotspots: Maintenance risk is MEDIUM (37/100). (impact 9)

Fix priorities

drift review

drift review

⚠️ Drift regressed: +0 score and 14 new issue(s).

  • Base ref: origin/master
  • Score delta: +0
  • New issues: 14
  • Resolved issues: 24

File breakdown

  • /home/runner/work/drift/drift/site/src/App.jsx: 100 -> 95 (-5), +9 new / -19 resolved
  • /home/runner/work/drift/drift/src/guard.ts: 18 -> 10 (-8), +0 new / -1 resolved
  • /home/runner/work/drift/drift/site/src/components/HeaderHero.jsx: 40 -> 30 (-10), +5 new / -4 resolved

@eduardbar
eduardbar merged commit d998093 into master Aug 3, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:quality Quality gates and testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant