dtls.c: add missing length checks in dtls_prepare_record. - #275
Open
boaks wants to merge 1 commit into
Open
Conversation
Signed-off-by: Achim Kraus <achim.kraus@cloudcoap.net>
obgm
reviewed
Sep 7, 2026
| } CCMNonceExample; | ||
| */ | ||
|
|
||
| if (*rlen < DTLS_RH_LENGTH + 8) { |
Contributor
There was a problem hiding this comment.
I have difficulties wrapping my head around this length check. The storage space for the 8 bytes written after this check are already included in DTLS_RH_LENGTH. Which fields are checked here actually?
Contributor
Author
There was a problem hiding this comment.
On a fast look, it seems that this is already considered in line 1680 with
if (*rlen < DTLS_RH_LENGTH) {
but the pain comes from the use of epoch+record-sequence-number as explicit nonce.
Therefore I check, if there is space for the 8 bytes of the explicit nonce. These bytes are located direct after the header.
Does this help?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.