Do not persist status line visibility under the perspective bar key - #4281
Open
vogella wants to merge 1 commit into
Open
Do not persist status line visibility under the perspective bar key#4281vogella wants to merge 1 commit into
vogella wants to merge 1 commit into
Conversation
setStatusLineVisible wrote the perspectiveBarVisible entry into the window's persisted state, so hiding the status line via WorkbenchWindowConfigurer.setShowStatusLine changed the perspective bar state on the next start. Nothing reads back a status line key, and the Hide Status Bar command persists through MUIElement.visible, so drop the write instead of adding a key. Also corrects the copy-pasted Javadoc. Introduced by 8a8be4d (Bug 403461 - Allow toggling toolbar on per-window basis).
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WorkbenchWindow.setStatusLineVisiblestored its value in the window's persisted state under theperspectiveBarVisiblekey. An RCP application callingWorkbenchWindowConfigurer.setShowStatusLine(false)therefore silently changed the perspective bar state for that window on the next start.Nothing ever reads a status line key back, and the Window > Appearance > Hide Status Bar command persists its state through
MUIElement.visibleon the status trim, so the write is dropped rather than replaced by a new key. The Javadoc of the two accessors was copied from the perspective bar methods and is corrected as well.The wrong key dates back to 8a8be4d (Bug 403461).