feat(setup-osc): Add a token input for authentication - #46
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
MarcelBochtler
requested changes
Sep 7, 2026
nnobelis
force-pushed
the
nnobelis/add_offline_token_support
branch
2 times, most recently
from
September 7, 2026 08:21
bb9991a to
90583ab
Compare
nnobelis
marked this pull request as ready for review
September 7, 2026 08:34
nnobelis
requested review from
Etsija,
bs-ondem,
lamppu,
mnonnenmacher,
oheger-bosch and
sschuberth
as code owners
September 7, 2026 08:34
mnonnenmacher
requested changes
Sep 8, 2026
nnobelis
force-pushed
the
nnobelis/add_offline_token_support
branch
from
September 10, 2026 13:39
362624d to
73370b4
Compare
mnonnenmacher
previously approved these changes
Sep 11, 2026
Contributor
|
Looks good from my side but @MarcelBochtler should have another look. @nnobelis have you tested that both ways to authenticate work with these changes? |
MarcelBochtler
requested changes
Sep 11, 2026
nnobelis
force-pushed
the
nnobelis/add_offline_token_support
branch
from
September 11, 2026 09:51
73370b4 to
8b69846
Compare
MarcelBochtler
requested changes
Sep 11, 2026
nnobelis
force-pushed
the
nnobelis/add_offline_token_support
branch
from
September 11, 2026 10:33
8b69846 to
6c13f1f
Compare
nnobelis
force-pushed
the
nnobelis/add_offline_token_support
branch
from
September 11, 2026 12:41
6c13f1f to
c5f3039
Compare
Allow authenticating with a token generated in the profile section of the ORT Server UI, as an alternative to the username/password couple. When `token` is set, `osc auth login` is called with `--token`. Fixes #45. Signed-off-by: Nicolas Nobelis <nicolas.nobelis@bosch.com>
nnobelis
force-pushed
the
nnobelis/add_offline_token_support
branch
from
September 11, 2026 13:08
f0f116c to
88de914
Compare
MarcelBochtler
approved these changes
Sep 11, 2026
Contributor
Author
|
Please do not merge. I will retest the changes on Monday. |
Contributor
Author
|
@mnonnenmacher Retested successfully with token and user/password, hence merging it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow authenticating with a token generated in the profile section of the ORT Server UI, as an alternative to the username/password couple. When
tokenis set,osc auth loginis called with--token.