Drop the retired recipes/ folder - #5
Merged
Merged
Conversation
@foleyjs/react and @foleyjs/vue replaced these copy-paste snippets in 2.3.1. They are not published (package.json ships src, README, LICENSE), nothing links them, and the only live reference is a test asserting the demo does NOT link them. They had started to rot: recipes/react.js carried its own useFoley with the pre-delegation "call bind() again" advice, so keeping it means a second source of truth drifting away from the real package. CHANGELOG history mentioning recipes/ stays - it is an accurate record.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recipes/react.jsandrecipes/vue.jswere superseded by@foleyjs/reactand@foleyjs/vuein 2.3.1. They are dead weight:package.jsonships["src", "README.md", "LICENSE"], so they never reach npm.test/packages.test.mjs:95, which asserts the demo does not link them.recipes/react.jscarries its own copy ofuseFoleywith the pre-delegation "callbind()again" advice. Once bind() delegates, and hover fires on keyboard focus #3 lands, that's a second source of truth contradicting the real package.Two file deletions, no code changes. 73 tests green.
CHANGELOG lines mentioning
recipes/are left alone — they're an accurate record of what happened, not stale docs.