Add Italian locale - #185
Open
LSalami wants to merge 1 commit into
Open
Conversation
Adds it.json alongside the existing en/zh-Hans catalogs, registers it in i18next resources, extends locale resolution (matchSupportedLocale, SUPPORTED_LOCALES) to recognize it-* device tags, wires it into the language picker in Settings, and generalizes the catalog-parity test to check all catalogs pairwise instead of just en vs zh-Hans.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
it.jsonalongside the existingen/zh-Hanscatalogs, translating every key.itin i18next resources (config.ts).SUPPORTED_LOCALESandmatchSupportedLocale(locale-resolve.ts) to recognizeit-*device tags.app/(tabs)/settings.tsx).catalog-parity.test.tsto check all catalogs pairwise instead of hardcoding en vs zh-Hans, so future locale additions are covered automatically.locale-resolve.test.ts.Test plan
npm test— all 334 tests pass (catalog parity, locale resolution, and the rest of the suite)npm run typecheck— no errors