Make output parsing robust to multi-line JSON and code blocks - #62
Merged
Conversation
The agent emitted IMPLEMENTATION_RESULT with a multi-line JSON object wrapped in a json code-block wrapping (in addition to the original single-line format). This is a safety net — the prompt should prevent it, but the parser should not fail if the agent formats the JSON differently. 2. Output contract: explicitly states the JSON must have exactly two fields (title and body), must not invent other fields, and must be on a single line without code-block wrapping. Added concrete examples of what not to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agent emitted
IMPLEMENTATION_RESULTwith a multi-line JSON object wrapped in a code block and invented its own fields (charms_modified,claim_tested, etc.) instead of using the requiredtitleandbody. Two fixes:1. Parser robustness
The regex now handles:
This is a safety net — the prompt should prevent it, but the parser should not fail if the agent formats the JSON differently.
2. Stronger output contract
The prompt now explicitly states:
titleandbodycharms_modified,claim_tested,run_tox_result, etc.)bodyas\n