Switch to JSON output format, add directness guidance - #59
Merged
Conversation
Three changes to fix issues with PR #58: 1. JSON output format: Replace IMPLEMENTATION_REASONING (plain text where the first line became the title) with IMPLEMENTATION_RESULT (JSON with separate 'title' and 'body' fields). The title must be a compact phrase (max 70 chars). The body must be proper markdown with headers, bullets, and code blocks. This separates the title from the body cleanly and prevents the agent from conflating them. 2. Directness guidance: Tell the agent to prefer straightforward tests over clever workarounds. No dynamically generated config files, no subprocess pytest, no meta-tests. Configure pyproject.toml directly and write tests that use the charm's own configuration. Remind the agent that there are four charms available for differential testing. 3. Workflow: Use --title-file and --body-file instead of --reasoning-file. The title and body are written to separate files by probe_issue.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three changes to fix issues with PR #58:
1. JSON output format
Replace
IMPLEMENTATION_REASONING(plain text where the first line became the title) withIMPLEMENTATION_RESULT(JSON with separatetitleandbodyfields). The title must be a compact phrase (max 70 chars). The body must be proper markdown with headers, bullets, and code blocks. This separates the title from the body cleanly and prevents the agent from conflating them.2. Directness guidance
Tell the agent to prefer straightforward tests over clever workarounds. No dynamically generated config files, no subprocess pytest, no meta-tests. Configure
pyproject.tomldirectly and write tests that use the charm's own configuration. Remind the agent that there are four charms available for differential testing.3. Workflow
Use
--title-fileand--body-fileinstead of--reasoning-file. The title and body are written to separate files byprobe_issue.py.Verification
uvx ruff format— passesuvx ruff check— passesuvx ty check— passesparse_decisiontested with sample JSON input — passes