chore: pin ruff lint select to E/F, unpin ruff version - #277
Merged
Conversation
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Changes
Root cause: the repo had no explicit ruff
select, so linting floated on ruff's implicit default. ruff 0.16 broadened that default substantially (turned onB/UP/I/PL/RUF/DTZ/… by default). Same config, same tree: 0.15 flagged 2, 0.16 flagged ~190 — which is why #275 had to pinruff<0.16to keep CI green.This makes the rule set explicit instead of inherited:
[tool.ruff.lint] select = ["E4", "E7", "E9", "F"]— the historicalE/Fdefault. The enforced rules no longer change when ruff's defaults change, so a future ruff release can't silently break CI again.ruff<0.16→ruff).ruff check ./srcpasses under ruff 0.16 with no code changes.Deliberately out of scope: adopting 0.16's new rule families (bugbear, pyupgrade, isort, pylint, …). That's an intentional decision, not something to inherit by accident — broaden
selectwhen the team wants those rules and fix/ignore each on purpose.Link to Issues
Follow-up to #275.
PR Review Checklist
ruff check ./srcpasses under ruff 0.16 with the explicit select;srcis unchanged so the unit suite is unchanged frommain.